[libvirt] [PATCH 0/4] qemu: handle ',' and '=' in VM names

Cole Robinson crobinso at redhat.com
Fri Apr 22 22:46:52 UTC 2016


This series adds qemu cli comma escaping to several places that
are dependent on the VM name, to enable names with embedded commas.

Patch 4 makes use of qemu -name guest=X value to allow names with
'=' in them.

There's likely other places that are VM name dependent that need
escaping too, but this hits the mandatory ones. I'm going to through
the remaining list on the BiteSizedTasks page

Cole Robinson (4):
  qemu: command: escape commas in VM name
  qemu: command: escape commas in secret master path
  qemu: command: escape commas in chardev socket path
  qemu: command: Use -name guest= if available

 src/qemu/qemu_capabilities.c                       |  2 ++
 src/qemu/qemu_capabilities.h                       |  1 +
 src/qemu/qemu_command.c                            | 22 ++++++++++++--------
 tests/qemucapabilitiesdata/caps_2.1.1-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.4.0-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.5.0-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0-1.caps       |  1 +
 .../qemuxml2argvdata/qemuxml2argv-name-escape.args | 24 ++++++++++++++++++++++
 .../qemuxml2argvdata/qemuxml2argv-name-escape.xml  | 18 ++++++++++++++++
 tests/qemuxml2argvtest.c                           |  2 ++
 10 files changed, 65 insertions(+), 8 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.xml

-- 
2.7.3




More information about the libvir-list mailing list