[libvirt] [PATCH] qemu: Fix off-by-one error in block I/O throttle messages

Martin Kletzander mkletzan at redhat.com
Mon Apr 25 09:57:54 UTC 2016


QEMU_BLOCK_IOTUNE_MAX is the maximum inclusively, so let's modify the
message so it makes sense.

https://bugzilla.redhat.com/show_bug.cgi?id=1329041

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 src/qemu/qemu_command.c | 2 +-
 src/qemu/qemu_driver.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ef4a62dafb5b..9597b307e9de 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1409,7 +1409,7 @@ qemuBuildDriveStr(virConnectPtr conn,
         disk->blkdeviotune.size_iops_sec > QEMU_BLOCK_IOTUNE_MAX) {
         virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
                       _("block I/O throttle limit must "
-                        "be less than %llu using QEMU"), QEMU_BLOCK_IOTUNE_MAX);
+                        "be no more than %llu using QEMU"), QEMU_BLOCK_IOTUNE_MAX);
         goto error;
     }

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 90f541cf6d74..91ed0fa4595a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17529,7 +17529,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
         if (param->value.ul > QEMU_BLOCK_IOTUNE_MAX) {
             virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
                            _("block I/O throttle limit value must"
-                             " be less than %llu"), QEMU_BLOCK_IOTUNE_MAX);
+                             " be no more than %llu"), QEMU_BLOCK_IOTUNE_MAX);
             goto endjob;
         }

-- 
2.8.1




More information about the libvir-list mailing list