[libvirt] [PATCH v2] qemu: conf: Set default logging approach in virQEMUDriverConfigNew

Peter Krempa pkrempa at redhat.com
Wed Apr 27 14:35:37 UTC 2016


Instead of setting the default qemu stdio logging approach in
virQEMUDriverConfigLoadFile set it in virQEMUDriverConfigNew so that
it's properly set even when the config is not present.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325075
---
 src/qemu/qemu_conf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 77ef4fe..5ed5776 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -324,6 +324,7 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged)
     cfg->seccompSandbox = -1;

     cfg->logTimestamp = true;
+    cfg->stdioLogD = true;

 #ifdef DEFAULT_LOADER_NVRAM
     if (virQEMUDriverConfigLoaderNVRAMParse(cfg, DEFAULT_LOADER_NVRAM) < 0)
@@ -812,8 +813,6 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg,
             goto cleanup;
         }
         VIR_FREE(stdioHandler);
-    } else {
-        cfg->stdioLogD = true;
     }

     GET_VALUE_ULONG("max_queued", cfg->maxQueuedJobs);
-- 
2.8.1




More information about the libvir-list mailing list