[libvirt] [PATCH v3] qemu: Regenerate VNC socket paths

Pavel Hrdina phrdina at redhat.com
Thu Apr 28 14:05:27 UTC 2016


On Thu, Apr 28, 2016 at 01:53:21PM +0200, Martin Kletzander wrote:
> Similarly to what commit 714080791778 did with some internal paths,
> clear vnc socket paths that were generated by us.  Having such path in
> the definition can cause trouble when restoring the domain.  The path is
> generated to the per-domain directory that contains the domain ID.
> However, that ID will be different upon restoration, so qemu won't be
> able to create that socket because the directory will not be prepared.
> 
> To be able to migrate to older libvirt, skip formatting the socket path
> in migratable XML if it was autogenerated.  And mark it as autogenerated
> if it already exists and we're parsing live XML.
> 
> Best viewed with '-C'.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1326270
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---

ACK and safe for freeze.




More information about the libvir-list mailing list