[libvirt] [PATCH] qemu: perf: Tweak flags before using them

Michal Privoznik mprivozn at redhat.com
Fri Apr 1 07:11:25 UTC 2016


On 31.03.2016 16:48, Peter Krempa wrote:
> @flags have a valid modification impact only after calling
> virDomainObjUpdateModificationImpact. virDomainObjGetOneDef calls it but
> doesn't update them in the caller.
> ---
> CC: mprivozn at redhat.com
> 
>  src/qemu/qemu_driver.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4aa1625..0434438 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10150,6 +10150,9 @@ qemuDomainGetPerfEvents(virDomainPtr dom,
>      if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
>          goto cleanup;
> 
> +    if (virDomainObjUpdateModificationImpact(vm, &flags) < 0)
> +        goto endjob;
> +
>      if (!(def = virDomainObjGetOneDef(vm, flags)))
>          goto endjob;
> 

ACK

Michal




More information about the libvir-list mailing list