[libvirt] [PATCH 2/2] netdev: Use the correct pointer type for virSocketAddrFormat()

[Andrea Bolognani]

On Fri, 2016-04-08 at 12:44 +0300, Roman Bogorodskiy wrote:
> On a related note, there's one more issue in this function related to
> the peer address support addition. It contains a code like this:
> 
> 1466     if (peerstr)
> 1467         virCommandAddArgList(cmd, "pointopoint", peerstr, NULL);
> 
> This should work on Linux, but FreeBSD's ifconfig has no support for the
> "pointopoint" keyword, the syntax is just "ifconfig $if $addr
> $peer_addr". I'll add a fix for that a little later as soon as I figure
> out how to give it a real test. Unfortunately, I see no easy way to
> detect presence of this keyword in ifconfig, so I guess it's going to be
> one more "#ifdef __linux__" knob.
> 
> PS Also, appears that a command like this:
> 
> ifconfig tun0 inet 192.168.77.0/24 192.168.77.12 broadcast 192.168.77.255
> 
> Actually sets peer address to 192.168.77.255. So need to figure out if
> we need to set broadcast if have peer address.

I'll leave fixes related to the FreeBSD userland to you, as my
experience with that OS is actually pretty limited :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team