[libvirt] [PATCH 12/18] domain_conf: cleanup virDomainGraphicsListenDefParseXML

Ján Tomko jtomko at redhat.com
Fri Apr 8 16:41:05 UTC 2016


On Mon, Apr 04, 2016 at 03:20:29PM +0200, Pavel Hrdina wrote:
> Use VIR_APPEND_ELEMENT_COPY_INPLACE to add listen elements into listens
> array while parsing.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/conf/domain_conf.c | 27 ++++++++++++++++-----------
>  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 1f6e9f4..a5da4b3 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -10606,7 +10606,7 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node,
>  }
>  
>  static int
> -virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDefPtr def,
> +virDomainGraphicsListenDefParseXML(virDomainGraphicsDefPtr def,

I prefer the original version where the function only touches the one
single ListenDef it is parsing.

Jan




More information about the libvir-list mailing list