[libvirt] [PATCH 0/2] host-validate: Don't build on Windows
Cole Robinson
crobinso at redhat.com
Fri Apr 8 18:03:24 UTC 2016
On 04/08/2016 12:04 PM, Andrea Bolognani wrote:
> The recent fixes to virt-host-validate have caused the mingw
> build to fail[1].
>
> Instead of working around Windows' quirks in the tool, just
> stop building it altogether - it's not like it made any
> sense to have it available on that OS anyway.
>
> Cheers.
>
>
> [1] https://ci.centos.org/view/libvirt-project/job/libvirt-mingw/1496/
>
> Andrea Bolognani (2):
> tools: Reorganize conditional bits
> configure: Make virt-host-validate optional
>
> configure.ac | 29 ++++++++++++++++++-----------
> m4/virt-host-validate.m4 | 40 ++++++++++++++++++++++++++++++++++++++++
> tools/Makefile.am | 35 ++++++++++++++++++-----------------
> 3 files changed, 76 insertions(+), 28 deletions(-)
> create mode 100644 m4/virt-host-validate.m4
>
I applied them both, tried 'make distcheck', and hit:
/usr/bin/install -c -m 644 ../../../tools/virt-host-validate.1
../../../tools/virt-pki-validate.1 ../../../tools/virt-xml-validate.1
../../../tools/virsh.1 ../../../tools/virt-admin.1
../../../tools/virt-login-shell.1 ../../../tools/virt-host-validate.1
'/home/crobinso/src/libvirt/libvirt-1.3.4/_inst/share/man/man1'
/usr/bin/install: will not overwrite just-created
'/home/crobinso/src/libvirt/libvirt-1.3.4/_inst/share/man/man1/virt-host-validate.1'
with '../../../tools/virt-host-validate.1'
Makefile:2863: recipe for target 'install-man1' failed
make[4]: *** [install-man1] Error 1
make[4]: *** Waiting for unfinished jobs....
Makefiles suck :)
- Cole
More information about the libvir-list
mailing list