[libvirt] [libvirt-php PATCH 00/35] Add PHP7 support and unit tests

Neal Gompa ngompa13 at gmail.com
Fri Apr 8 22:08:09 UTC 2016


First, I apologize if this was sent twice to anyone. I had an error
in my git send-email configuration.

This patch set primarily adds support for PHP 7 to libvirt-php,
but also adds the capability for libvirt-php to be built
using the standard PHP extension build system method.

Several tests have been updated and added by Remi Collet (Fedora PHP stack maintainer)
and Frederic Mora (my colleague who graciously assisted in this effort).
I intend to provide more tests over time, but I think this is a good start.
These tests can be run through `make tests` in the new build system.
Instructions for using the new build system is also included.

The original build system still properly builds libvirt-php on
either PHP 5.6 or PHP 7.0. This was tested using Remi's PHP 5.6
and PHP 7.0 software collections on CentOS 7.2.

Most of this work was done by Remi Collet several weeks ago,
with Chuck Roydhouse doing work to ensure that Vasiliy Tolstov's
patches from the current git master could be incorporated into this work.
They are included in this patch set, but should be the same as what is
in the tree now. This work started before he posted his commits and
they were merged, and were merged in to ensure that it could remain
working.

The version number was bumped to 0.5.2 by Remi, and I bumped it in the
main build system simply for consistency.

I would greatly appreciate a quick review and merge of this patch set.

Chuck Roydhouse (1):
  add arginfo for libvirt_domain_block_commit and
    libvirt_domain_block_job_info

Frederic Mora (1):
  Add more tests

Neal Gompa (2):
  Commit short instructions to using the php extension build method
  Bump version to 0.5.2

Remi Collet (28):
  add config.m4 to allow standard PHP extension build system
  include config.h earlier
  add missing arginfo (wip)
  fix typo in config.m4
  add missing arginfo, part 2
  adapt RETURN_STRING
  work on zpp
  register + fetch resources + hash
  adapt add_assoc_string_ex
  clean ALLOC_INIT_ZVAL
  zend_hash_update
  add_next_index_string
  buildable with PHP 7
  bump version 0.5.2-dev
  fix zpp
  fix missed (hidden) zpp calls
  fix PHP 5 compat
  fix libvirt_version + add test
  port test-connect.phpt to real phpt
  Switch all add_assoc_string_ex to add_assoc_string to avoid nul char
    management
  Fix max_connections management
  add test-conn-limit.phpt (as real phpt)
  add test-connect-get-emulator.phpt
  fix parse_array + build warnings
  convert test-install.phpt to real phpt
  convert test-domain-create-and-coredump.phpt to real phpt
  convert test-domain-create-and-get-xpath.phpt to real phpt
  fix PHP 5 compat again (nested macro issue)

Vasiliy Tolstov (3):
  add some checks to prevent overflow
  add block_commit support and needed const
  add libvirt_domain_block_job_info




More information about the libvir-list mailing list