[libvirt] [PATCH] po: fix POTFILES.in file ordering

Pavel Hrdina phrdina at redhat.com
Sun Apr 10 12:03:43 UTC 2016


On Sat, Apr 09, 2016 at 08:10:55PM +0200, Erik Skultety wrote:
> When it comes to a situation that a new translatable file needs to be added
> into the list of files, an automatically generated patch is proposed during
> syntax-check. However, the diff was made against a sorted list of files and
> the same sorted list of files + the new file that actually needs to be added
> into the list. Since we do not keep POTFILES sorted, the proposed patch thus
> can't be applied...most of the time - depending on the context.
> 
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  po/POTFILES.in | 68 +++++++++++++++++++++++++++++-----------------------------
>  1 file changed, 34 insertions(+), 34 deletions(-)

This is sorted for different locales (my guess is en_US).  Libvirt uses LC_ALL=C
(see maint.mk:145) and you should use this command:

    LC_ALL=C sort po/POTFILES.in -o po/POTFILES.in

Fix this please and send a new patch :)

Pavel




More information about the libvir-list mailing list