[libvirt] [PATCH 1/3] qemuhotplugtest: Allow testing of live data

[Martin Kletzander]

On Thu, Mar 31, 2016 at 08:29:52AM -0400, John Ferlan wrote:
>On 03/30/2016 11:13 AM, Martin Kletzander wrote:
>> For now, the test was dumping an XML of inactive domain (well, setting
>> the id to '-1' to be precise) when checking the results.  This patch
>> enables future additions to test the live XML output as well.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  tests/qemuhotplugtest.c | 27 +++++++++++++++++----------
>>  1 file changed, 17 insertions(+), 10 deletions(-)
>>
>> diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
>> index 1eb2b6a881f2..2b0de94fb4a6 100644
>> --- a/tests/qemuhotplugtest.c
>> +++ b/tests/qemuhotplugtest.c
>> @@ -371,7 +374,7 @@ mymain(void)
>>      /* wait only 100ms for DEVICE_DELETED event */
>>      qemuDomainRemoveDeviceWaitTime = 100;
>>
>> -#define DO_TEST(file, ACTION, dev, event, fial, kep, ...)                   \
>> +#define DO_TEST(file, ACTION, dev, event, fial, kep, liv, ...)              \
>
>"Typically" rather than misspelling "fail", "keep", or "live" one would
>use an underscore, such as "_fail", "_keep", and "_live" in order to
>represent a macro argument...
>
>Not required for ACK, but nice nonetheless
>

I didn't want to get to discussions about this so I followed what was
already used in this file (and bunch of others as well).  If I were to
change this, it would go into separate patch anyway, so it doesn't make
sense to change in this one, I believe.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160412/a8d9b713/attachment-0001.sig>