[libvirt] [PATCH 12/12] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

[John Ferlan]

[...]

>  configure.ac            |   1 +
>  src/qemu/qemu_alias.c   |  23 ++++++
>  src/qemu/qemu_alias.h   |   2 +
>  src/qemu/qemu_command.c | 126 ++++++++++++++++++++++++++++++
>  src/qemu/qemu_command.h |   4 +
>  src/qemu/qemu_domain.c  | 199 +++++++++++++++++++++++++++++++++++++++++++++---
>  src/qemu/qemu_domain.h  |   3 +
>  src/qemu/qemu_hotplug.c |  72 +++++++++++++++++-
>  8 files changed, 418 insertions(+), 12 deletions(-)
> 

Digging in deeper to the testing portion proves to me more is needed on
this patch - in particular qemuDomainSecretIVSetup has a couple of
issues. One being, I needed to do an "if (secret)" in the cleanup
section since I VIR_FREE'd it earlier. It was all cleanup, then I
thought - probably should clear/free the secret right after using - bad
idea ;-)...  I also have something not quite right because when the
object is passed to qemu and the decrypt is done, the answer isn't
correct - even though if I "add" a decrypt call and check the result, I
get the right answer.  Perhaps something to do with the padding - still
not quite sure.

Also, I neglected to think about hotunplug and removing the object...

John

[...]