[libvirt] [libvirt-php PATCH 00/29] Add PHP7 support and unit tests V2

Neal Gompa ngompa13 at gmail.com
Wed Apr 13 16:13:05 UTC 2016


This patch set is a revision of the first version, taking into account
some of the feedback from Michal Privoznik.

I've done some patch surgery to rebase the patch set on the current
git HEAD, so it should cleanly apply as-is. Additionally, I've squashed
a few commits (mainly some of Remi's patches that were squashable
that should be squashed). This means that Vasiliy's patches are
no longer unnecessarily part of this patch set.

I've updated my patches for the instructions on the php extension build
system method to correct a typo on how to run the tests
(`make test` instead of `make tests`) and removed the "-dev" suffix
that Remi attached to the version string in libvirt-php.h, as I expect
that there will likely be a libvirt-php release after this patch set is merged.

I would greatly appreciate a quick review and merge of this patch set.

Chuck Roydhouse (1):
  add arginfo for libvirt_domain_block_commit and
    libvirt_domain_block_job_info

Frederic Mora (1):
  Add more tests

Neal Gompa (2):
  Commit short instructions to using the php extension build method
  Bump version to 0.5.2

Remi Collet (25):
  add config.m4 to allow standard PHP extension build system
  include config.h earlier
  add missing arginfo
  adapt RETURN_STRING
  work on zpp
  register + fetch resources + hash
  adapt add_assoc_string_ex
  clean ALLOC_INIT_ZVAL
  zend_hash_update
  add_next_index_string
  buildable with PHP 7
  bump version 0.5.2-dev
  fix missed (hidden) zpp calls
  fix PHP 5 compat
  fix libvirt_version + add test
  port test-connect.phpt to real phpt
  Switch all add_assoc_string_ex to add_assoc_string to avoid nul char
    management
  Fix max_connections management
  add test-conn-limit.phpt (as real phpt)
  add test-connect-get-emulator.phpt
  fix parse_array + build warnings
  convert test-install.phpt to real phpt
  convert test-domain-create-and-coredump.phpt to real phpt
  convert test-domain-create-and-get-xpath.phpt to real phpt
  fix PHP 5 compat again (nested macro issue)

 INSTALL.PHPEXT                                  |   14 +
 configure.ac                                    |    2 +-
 src/config.m4                                   |   52 +
 src/libvirt-php.c                               | 1796 ++++++++++++++++-------
 src/libvirt-php.h                               |   48 +-
 src/tests/example-no-disk-and-media.xml         |   41 +
 src/tests/qemu-no-disk-and-media.xml            |   41 +
 src/tests/skipif.inc                            |    3 +
 src/tests/test-conn-limit.phpt                  |   49 +
 src/tests/test-connect-get-capabilities.phpt    |   27 +
 src/tests/test-connect-get-emulator.phpt        |   15 +
 src/tests/test-connect-get-info.phpt            |  110 ++
 src/tests/test-connect-get-machine-types.phpt   |   30 +
 src/tests/test-connect.phpt                     |   15 +
 src/tests/test-domain-create-and-coredump.phpt  |   49 +
 src/tests/test-domain-create-and-get-xpath.phpt |   56 +
 src/tests/test-domain-create-and-shutdown.phpt  |   38 +
 src/tests/test-domain-define.phpt               |   38 +
 src/tests/test-domain-disk.phpt                 |   71 +
 src/tests/test-domain-get.phpt                  |   91 ++
 src/tests/test-domain-lookup-by-name.phpt       |   35 +
 src/tests/test-domain-nic.phpt                  |   52 +
 src/tests/test-install.phpt                     |  136 ++
 src/tests/test-libvirt-php.img                  |    0
 src/tests/test-logfile.phpt                     |   43 +
 src/tests/test-version-get.phpt                 |   27 +
 26 files changed, 2330 insertions(+), 549 deletions(-)
 create mode 100644 INSTALL.PHPEXT
 create mode 100644 src/config.m4
 create mode 100644 src/tests/example-no-disk-and-media.xml
 create mode 100644 src/tests/qemu-no-disk-and-media.xml
 create mode 100644 src/tests/skipif.inc
 create mode 100644 src/tests/test-conn-limit.phpt
 create mode 100644 src/tests/test-connect-get-capabilities.phpt
 create mode 100644 src/tests/test-connect-get-emulator.phpt
 create mode 100644 src/tests/test-connect-get-info.phpt
 create mode 100644 src/tests/test-connect-get-machine-types.phpt
 create mode 100644 src/tests/test-connect.phpt
 create mode 100644 src/tests/test-domain-create-and-coredump.phpt
 create mode 100644 src/tests/test-domain-create-and-get-xpath.phpt
 create mode 100644 src/tests/test-domain-create-and-shutdown.phpt
 create mode 100644 src/tests/test-domain-define.phpt
 create mode 100644 src/tests/test-domain-disk.phpt
 create mode 100644 src/tests/test-domain-get.phpt
 create mode 100644 src/tests/test-domain-lookup-by-name.phpt
 create mode 100644 src/tests/test-domain-nic.phpt
 create mode 100644 src/tests/test-install.phpt
 create mode 100644 src/tests/test-libvirt-php.img
 create mode 100644 src/tests/test-logfile.phpt
 create mode 100644 src/tests/test-version-get.phpt

-- 
2.5.5




More information about the libvir-list mailing list