[libvirt] [PATCH v4 0/6] vz: change vz driver to be stateful driver and other enhancements
Laine Stump
laine at laine.org
Wed Apr 13 18:40:29 UTC 2016
On 04/13/2016 11:55 AM, Maxim Nestratov wrote:
> 13.04.2016 17:31, Nikolay Shirokovskiy пишет:
>>
>> On 13.04.2016 16:07, Maxim Nestratov wrote:
>>> There is no benefit in providing two ways of connecting to vz driver:
>>> by connecting via daemon and directly from client. Both ways finally
>>> come to a host where vz daemon sits. Always connecting via daemon
>>> allows
>>> us to have a single list of domains and share it among all connections.
>>>
>>> Since v1:
>>> removed patch "z: remove close callback implementations"
>>> building fixed
>>> close callback functions are added to libvirt_private.syms
>>> reworked not to lose event subscribers when connections drop
>>>
>>> Since v2:
>>> removed "vz: change vzConnectIsAlive behavior"
>>> addressed mostly all comments on previous series
>>> changed "vz: build driver as module and don't register it on
>>> client's side"
>>>
>>> Since v3:
>>> removed privileged check in vzStateInitialize, we will not work in
>>> non-
>>> privileged mode anyway, while skipping initialization is not correct
>>> because cleanup function will be called anyway
>>> prlsdkNewDomainByHandle changed to check for domain presense in
>>> the list
>>> under lock
>>>
>>> Maxim Nestratov (6):
>>> vz: build driver as module and don't register it on client's side
>>> vz: introduce new vzDriver lockable structure and use it
>>> vz: fix possible vzDomainDefineXMLFlags and
>>> prlsdkNewDomainByHandle race
>>> vz: implement connectGetSysinfo hypervisor callback
>>> vz: remove vzDriverLock/Unlock function
>>> vz: minor cleanup
>>>
>>> daemon/Makefile.am | 4 +
>>> daemon/libvirtd.c | 9 ++
>>> src/Makefile.am | 19 ++-
>>> src/libvirt.c | 7 -
>>> src/libvirt_private.syms | 7 +
>>> src/vz/vz_driver.c | 384
>>> +++++++++++++++++++++++++++++------------------
>>> src/vz/vz_sdk.c | 211 +++++++++++++-------------
>>> src/vz/vz_sdk.h | 30 ++--
>>> src/vz/vz_utils.c | 27 ++--
>>> src/vz/vz_utils.h | 34 +++--
>>> 10 files changed, 431 insertions(+), 301 deletions(-)
>>>
>> ACK to series
>
> PUSHed.
One of the patches in this series breaks the build when the vz driver is
disabled:
./vz/vz_driver.c:1562 Missing ACL check in function 'vzConnectOpen' for
'connectOpen'
./vz/vz_driver.c:1564 Missing ACL check in function
'vzConnectGetVersion' for 'connectGetVersion'
./vz/vz_driver.c:1565 Missing ACL check in function
'vzConnectGetHostname' for 'connectGetHostname'
./vz/vz_driver.c:1566 Missing ACL check in function
'vzConnectGetSysinfo' for 'connectGetSysinfo'
./vz/vz_driver.c:1567 Missing ACL check in function
'vzConnectGetMaxVcpus' for 'connectGetMaxVcpus'
./vz/vz_driver.c:1568 Missing ACL check in function 'vzNodeGetInfo' for
'nodeGetInfo'
etc.
I'm still investigating.
> Thanks,
> Maxim
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
More information about the libvir-list
mailing list