[libvirt] may be bug in my own commit?

Vasiliy Tolstov v.tolstov at selfip.ru
Thu Apr 14 07:13:47 UTC 2016


Hi. I'm try to backport some my changes to centos libvirt (1.2.17),
and see that may be i miss IFA_ADDRESS when peerData is null, can
somebody recheck me?
https://libvirt.org/git/?p=libvirt.git;a=blobdiff;f=src/util/virnetdev.c;h=6e32ebbf6cee8a9711a8065bc0baf169f58974aa;hp=aed50f54626365ecf546a9e3edaeb5434c67255d;hb=b3d069872ce53eb2ad058bda9ea8e27436be7020;hpb=216650f14b35ad11a45505405347f8027bc294d7

-    if (nla_put(nlmsg, IFA_ADDRESS, addrDataLen, addrData) < 0)
-        goto buffer_too_small;
+    if (peerData) {
+        if (nla_put(nlmsg, IFA_ADDRESS, addrDataLen, peerData) < 0)
+            goto buffer_too_small;
+    }

This misses else i think..

-- 
Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru




More information about the libvir-list mailing list