[libvirt] [PATCH] qemu: reject min_guarantee at parse time

[Cole Robinson]

On 04/16/2016 08:54 AM, Martin Kletzander wrote:
> On Fri, Apr 15, 2016 at 05:37:17PM -0400, Cole Robinson wrote:
>> min_guarantee isn't implemented for qemu, and an explicit check was
>> added in june 2014 to reject the VM at qemu startup time. It's a weird
>> place to do XML validation, so move it to the post parse area where
>> we have similar checks.
>>
> 
> NACK, it's done precisely there because if there is any domain that has
> that parameter already in, it will disappear after upgrade to libvirt
> with this patch.  That's what we have that validation function for and
> the reason why it is called when the domain is being started.
> 
> We have bunch of similar issues that I wanted to address globally, but
> it doesn't look like it will work in near future.
> 

I see what you mean. In this case it's a bit fuzzy since that particular check
has been there since Aug 2014, so I strongly doubt there's any configs in
practice that have that param set on anything recent. But it's a fairly
pedantic point, I'll change the patch to add a comment about the deliberate
location choice.

Thanks,
Cole