[libvirt] [PATCH 0/7] Probe and expose GIC capabilities
Andrea Bolognani
abologna at redhat.com
Tue Apr 19 08:52:02 UTC 2016
On Mon, 2016-04-18 at 19:43 +0200, Andrea Bolognani wrote:
> Changes from [RFC]:
>
> * Fix issues pointed out during review (see patches
> 1 and 2 for details)
>
> * Add documentation
>
> The only thing missing AFAIK is some test cases... I'm not sure
> whether it's possible to include QMP replies for QEMU 2.6 even
> though it hasn't been released yet, and I wouldn't know how to
> generate a .replies file anyway. Any pointers?
Things I forgot to mention yesterday:
* John suggested squashing some patches together, but I
haven't done so because my understanding is that it would
just have made review easier, and I think at this point
deviating from the RFC would actually have the opposite
effect. I'm not against doing so, though
* It was also questioned whether patch 6, which deals with
saving and restoring the QEMU capabilities, should appear
earlier in the series. I don't expect a feature to work
properly until the whole series has been applied, so I
don't think it's worth shuffling patches around just
because of that, but I could be convinced otherwise
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team
More information about the libvir-list
mailing list