[libvirt] [PATCH 2/4] examples: Try harder to uninstall nwfilter

John Ferlan jferlan at redhat.com
Tue Apr 19 14:20:01 UTC 2016



On 04/19/2016 09:50 AM, Michal Privoznik wrote:
> We have this code in our Makefile that tries to remove
> /etc/libvirt/nwfilter if directory is left empty after all our
> example nwfilters were uninstalled. However, the check for that
> is missing quotation marks thus rendering the test useless:
> 
> test -z allow-arp.xml allow-dhcp-server.xml .. qemu-announce-self.xml || \
>   rmdir "/some/path/libvirt.git/_install/etc/libvirt/nwfilter"
> /bin/sh: line 0: test: too many arguments
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  examples/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK

John




More information about the libvir-list mailing list