[libvirt] [PATCH 2/7] qemu: Probe GIC capabilities

Cole Robinson crobinso at redhat.com
Tue Apr 19 22:34:31 UTC 2016


On 04/18/2016 01:43 PM, Andrea Bolognani wrote:
> QEMU introduced the query-gic-capabilities QMP command
> with commit 4468d4e0f383: use the command, if available,
> to probe available GIC capabilities.
> 
> The information obtained is stored in a virQEMUCaps
> instance, and will be later used to fill in a
> virDomainCaps instance.
> ---
> Changes from RFC:
> 
>   * Free qemuCaps->gicCapabilities when needed
> 
>   * Always return NULL when no capabilities have been found
> 
>   * Don't allocate (n+1) elements to store (n) capabilities
> 
>   * Check for ARM consistently with the rest of the code
> 
>   * Reference QEMU commit
> 
>   * Leave two empty lines between functions
> 
>   * Document all functions
> 
>  src/qemu/qemu_capabilities.c |  42 ++++++++++++++++
>  src/qemu/qemu_monitor.c      |  17 +++++++
>  src/qemu/qemu_monitor.h      |   4 ++
>  src/qemu/qemu_monitor_json.c | 115 +++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h |   4 ++
>  src/util/virgic.h            |  13 +++++
>  6 files changed, 195 insertions(+)

ACK

- Cole




More information about the libvir-list mailing list