[libvirt] [PATCH 1/4] build: Always use $(LN_S) and $(MKDIR_P)

Andrea Bolognani abologna at redhat.com
Wed Apr 20 18:00:27 UTC 2016


autotools provide those for our convenience, so let's use them
everywhere instead of mixing in native command invocation.
---
 Makefile.am     | 2 +-
 src/Makefile.am | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 9298082..d6f09ba 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -68,7 +68,7 @@ rpm: clean
 check-local: all tests
 
 cov: clean-cov
-	mkdir $(top_builddir)/coverage
+	$(MKDIR_P) $(top_builddir)/coverage
 	$(LCOV) -c -o $(top_builddir)/coverage/libvirt.info.tmp \
 	  -d $(top_builddir)/src  -d $(top_builddir)/daemon \
 	  -d $(top_builddir)/tests
diff --git a/src/Makefile.am b/src/Makefile.am
index ad1c0c3..0380695 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -3079,7 +3079,7 @@ if WITH_NETWORK
 	      $(DESTDIR)$(confdir)/qemu/networks/default.xml && \
 	    rm $(DESTDIR)$(confdir)/qemu/networks/default.xml.t; }
 	test -e $(DESTDIR)$(confdir)/qemu/networks/autostart/default.xml || \
-	   ln -s ../default.xml \
+	   $(LN_S) ../default.xml \
 	    $(DESTDIR)$(confdir)/qemu/networks/autostart/default.xml
 endif WITH_NETWORK
 
-- 
2.5.5




More information about the libvir-list mailing list