[libvirt] [PATCH 5/8] conf: Add disk iothread bus check in device post parse

Peter Krempa pkrempa at redhat.com
Fri Apr 22 07:04:28 UTC 2016


On Thu, Apr 21, 2016 at 19:24:13 -0400, John Ferlan wrote:
> Add a check in the device post processing for any disk using iothread to be
> using the proper bus (which happens to be only virtio for now).
> 
> This check could have been added in device parse, except that if a domain
> was running with such a configuration (albeit doing nothing), then it
> would disappear. Found while working through code to add iothreads for
> virtio-scsi-{pci,ccw}.

This is still called when parsing and makes the domain disappear.

> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/domain_conf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index a3c50f1..fd7579a 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -4187,6 +4187,13 @@ virDomainDeviceDefPostParseInternal(virDomainDeviceDefPtr dev,
>              return -1;
>          }
>  
> +        if (disk->iothread && disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO) {
> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> +                           _("disk '%s' improperly configured, iothread "
> +                             "only supported on virtio bus"), disk->dst);
> +            return -1;
> +        }
> +
>          if (disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
>              virDomainDiskDefAssignAddress(xmlopt, disk, def) < 0)
>              return -1;

NACK to this placement, you need to put it into qemuProcess..

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160422/fc9783e6/attachment-0001.sig>


More information about the libvir-list mailing list