[libvirt] [PATCH 00/13] build: Fix and improve man pages handling

[Andrea Bolognani]

On Fri, 2016-04-22 at 15:22 -0400, John Ferlan wrote:
> > 
> > Andrea Bolognani (13):
> >   build: Ship virt-admin.pod
> >   build: Extract pod from source files
> >   build: Build man pages in $(builddir)
> >   build: Perform post-processing on all man pages
> >   build: Standardize on .pod -> .x.in -> .x
> >   build: Never ship man pages
> >   build: Group files
> >   build: Ensure intermediate files are cleaned up properly
> >   build: Replace variables in man pages
> >   build: Always ship virt-login-shell.conf
> >   man: Fix NAME section
> >   man: Fix SYNOPSIS section
> >   man: Fix links
> > 
> >  daemon/Makefile.am                              |  43 +++++----
> >  daemon/{libvirtd.pod.in => libvirtd.pod}        |   4 +-
> >  src/Makefile.am                                 |  69 ++++++++------
> >  src/locking/{virtlockd.pod.in => virtlockd.pod} |   4 +-
> >  src/logging/{virtlogd.pod.in => virtlogd.pod}   |   4 +-
> >  tools/Makefile.am                               | 114 +++++++++++++++---------
> >  tools/virsh.pod                                 |   6 +-
> >  tools/virt-admin.pod                            |   6 +-
> >  tools/virt-host-validate.c                      |  74 ---------------
> >  tools/virt-host-validate.pod                    |  68 ++++++++++++++
> >  tools/virt-login-shell.pod                      |   3 +-
> >  tools/virt-pki-validate.in                      |  64 -------------
> >  tools/virt-pki-validate.pod                     |  61 +++++++++++++
> >  tools/virt-sanlock-cleanup.in                   |  52 -----------
> >  tools/virt-sanlock-cleanup.pod                  |  49 ++++++++++
> >  tools/virt-xml-validate.in                      | 113 -----------------------
> >  tools/virt-xml-validate.pod                     | 111 +++++++++++++++++++++++
> >  17 files changed, 440 insertions(+), 405 deletions(-)
> >  rename daemon/{libvirtd.pod.in => libvirtd.pod} (97%)
> >  rename src/locking/{virtlockd.pod.in => virtlockd.pod} (97%)
> >  rename src/logging/{virtlogd.pod.in => virtlogd.pod} (97%)
> >  create mode 100644 tools/virt-host-validate.pod
> >  create mode 100644 tools/virt-pki-validate.pod
> >  create mode 100644 tools/virt-sanlock-cleanup.pod
> >  create mode 100644 tools/virt-xml-validate.pod
> > 
> Changes seem reasonable to me (although not exactly my specialty).
> Should I assume you ran make dist or distcheck to ensure everything gets
> to the right place?

On several distributions... If anything weird pops up we can
just fix it after the fact.

> I'm missing some things so those don't work for me
> any more (first error for me was "recipe for target
> 'libvirt-daemon-arch.png' failed" - I didn't bother to dig).

Looks like those .png files are created from .fig files using
convert(1)... Do you have ImageMagick installed on your host?

> ACK

I've now pushed the series. Thanks for your review :)

-- 
Andrea Bolognani
Software Engineer - Virtualization Team