[libvirt] [PATCH] libvirtd.service: add NotifyService=all

[Serge Hallyn]

Quoting Daniel P. Berrange (berrange at redhat.com):
> On Mon, Apr 25, 2016 at 03:52:25PM +0000, Serge Hallyn wrote:
> > systemd.service(5) says that this should be set when using Type=notify,
> > and indeed we seem to have a bug report resulting from this not being set:
> 
> Not quite - the man page says it will default to NotifyAccess=main
> when not set, which on the surface ought to be fine for us. Setting
> it to NotifyAccess=all, allows non-main tasks to notify systemd
> ie things spawned by libvirtd. This doesn't seem like something
> we should need or want.

Oh, hm.  I figured any thread could do it.

If not then I guess this patch may be wrong.

> > https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1574566
> 
> I see that says:
> 
> Apr 25 12:38:11 hostname systemd[1]: libvirt-bin.service: Got notification message from PID 1038, but reception only permitted for main PID 1003
> 
> I thought at first this might be a case of not distinguishing between
> threads and processes, but libvirtd calls sd_notify() from its main
> thread IIUC.
> 
> Did the user have some kind of wrapper script around libvirtd, so
> libvirtd isn't the first thing being launched.

Hm, not that I know of;  but perhaps there is simply a libvirtd that
was started by hand or sysvinit or something.  I'll try get some more
info.

thanks

-serge