[libvirt] [PATCH 0/4] apibuild: Fix several issues

[Cole Robinson]

On 04/25/2016 09:20 AM, Andrea Bolognani wrote:
> My home directory contains
> 
>   src/upstream/libvirt - git repository
>   src/libvirt          - symbolic link to the above
> 
> and since d195cffa2e1b I can no longer build in-tree because
> make passes
> 
>   srcdir=.
>   builddir=$HOME/src/libvirt/docs
> 
> to apibuild.py, which get converted to
> 
>   srcdir=$HOME/src/upstream/libvirt/docs
>   builddir=$HOME/src/libvirt/docs
> 
> inside the script and thus considered separate directories.
> This in turn leads to files being processed twice, and a
> bunch of definitions being reported as duplicates.
> 
> ... Well, kind of. The script *attempts* to report the
> failures, but fails while doing so :)
> 
> This series fixes both the build issue (1/4) and the failure
> to report build issues properly (2/4), plus some more of the
> latter that I noticed while working on the code (3/4, 4/4).
> 
> Last but not least: I'm not a pythonista, so feel free to
> point out unpythonic code.

The entire file is quite unpythonic by modern standards so IMO not worth
nitpicking over.

All 4 look fine to me, ACK

- Cole