[libvirt] [PATCH v2 2/3] libxl: fix segfault in libxlReconnectDomain

Michal Privoznik mprivozn at redhat.com
Tue Aug 2 13:38:29 UTC 2016

On 28.07.2016 11:57, Cédric Bosdonnat wrote:
> In case of error, libxlReconnectDomain may call
> virDomainObjListRemoveLocked. However it has no local reference on
> the domain object, leading to segfault. Get a reference to the domain
> object at the start of the function and release it at the end to avoid
> problems.
> This commit also factorizes code between the error and normal ends.
> ---
>  src/libxl/libxl_driver.c | 30 ++++++++++++++++++------------
>  1 file changed, 18 insertions(+), 12 deletions(-)

This fixes a real problem and is not strictly hook related. I don't
mind, but other's would. So you'd better switch this one with 1/3 and
push quickly :)


More information about the libvir-list mailing list