[libvirt] [PATCHv3 2a/9] qemu: Remove generation of drive alias from qcow passphrase backends

Ján Tomko jtomko at redhat.com
Tue Aug 2 14:02:55 UTC 2016


On Mon, Aug 01, 2016 at 08:23:37AM -0400, John Ferlan wrote:
>Rather than pass the disks[i]->info.alias to qemuMonitorSetDrivePassphrase
>and then generate the "drive-%s" alias from that, let's use qemuAliasFromDisk
>prior to the call to generate the drive alias and then pass that along
>thus removing the need to generate the alias from the monitor code.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
>
> Mainly so it's more apparent/transparent what I was planning to do.
> If you'd rather see the whole series again - that's not a problem...
>
> src/qemu/qemu_monitor_json.c | 7 +------
> src/qemu/qemu_monitor_text.c | 3 +--
> src/qemu/qemu_process.c      | 2 +-
> tests/qemumonitorjsontest.c  | 2 +-
> 4 files changed, 4 insertions(+), 10 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160802/758f1d14/attachment-0001.sig>


More information about the libvir-list mailing list