[libvirt] [PATCH 3/9] tests: qemuxml2xml: Fix disk-mirror

Ján Tomko jtomko at redhat.com
Thu Aug 4 10:57:27 UTC 2016


It's not really broken.

Maybe s/Fix/clean up/?

On Fri, Jul 29, 2016 at 07:46:23PM +0200, Andrea Bolognani wrote:
>Instead of testing it twice using WHEN_ACTIVE and WHEN_INACTIVE
>separately, just use WHEN_BOTH.
>---
> tests/qemuxml2xmltest.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
>index 5f04b8b..2af8245 100644
>--- a/tests/qemuxml2xmltest.c
>+++ b/tests/qemuxml2xmltest.c
>@@ -477,8 +477,7 @@ mymain(void)
>                  QEMU_CAPS_SCSI_MPTSAS1068,
>                  QEMU_CAPS_SCSI_DISK_WWN);
>     DO_TEST("disk-mirror-old");
>-    DO_TEST_FULL("disk-mirror", WHEN_ACTIVE, GIC_NONE, NONE);
>-    DO_TEST_FULL("disk-mirror", WHEN_INACTIVE, GIC_NONE, NONE);
>+    DO_TEST_FULL("disk-mirror", WHEN_BOTH, GIC_NONE, NONE);
>     DO_TEST_FULL("disk-active-commit", WHEN_ACTIVE, GIC_NONE, NONE);
>     DO_TEST("graphics-listen-network");
>     DO_TEST("graphics-vnc");
>-- 
>2.7.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160804/33c09c0d/attachment-0001.sig>


More information about the libvir-list mailing list