[libvirt] [PATCH 6/9] tests: qemuxml2xml: Use DO_TEST() for most tests

Ján Tomko jtomko at redhat.com
Thu Aug 4 11:09:02 UTC 2016


On Fri, Jul 29, 2016 at 07:46:26PM +0200, Andrea Bolognani wrote:
>Now that DO_TEST() can be passed capabilities, there is little
>need to use DO_TEST_FULL() instead of DO_TEST().
>---
> tests/qemuxml2xmltest.c | 353 ++++++++++++++++++++++--------------------------
> 1 file changed, 158 insertions(+), 195 deletions(-)
>

>@@ -655,152 +642,129 @@ mymain(void)
>     DO_TEST("metadata", NONE);
>     DO_TEST("metadata-duplicate", NONE);
>
>-    DO_TEST_FULL("pci-bridge", WHEN_BOTH, GIC_NONE,
>-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
>-    DO_TEST_FULL("pci-bridge-many-disks", WHEN_BOTH, GIC_NONE,
>-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
>-    DO_TEST_FULL("pci-autoadd-addr", WHEN_BOTH, GIC_NONE,
>-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
>-    DO_TEST_FULL("pci-autoadd-idx", WHEN_BOTH, GIC_NONE,
>-                 QEMU_CAPS_DEVICE_PCI_BRIDGE);
>+    DO_TEST("pci-bridge",
>+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
>+    DO_TEST("pci-bridge-many-disks",
>+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
>+    DO_TEST("pci-autoadd-addr",
>+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
>+    DO_TEST("pci-autoadd-idx",
>+            QEMU_CAPS_DEVICE_PCI_BRIDGE);
>     DO_TEST("pci-autofill-addr", NONE);
>

Now you can fit some of the tests on a single line.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160804/be977ae2/attachment-0001.sig>


More information about the libvir-list mailing list