[libvirt] [PATCH 3/5] Introduce @secure attribute to os loader element

[Pavel Hrdina]

On Thu, Aug 04, 2016 at 05:11:11PM +0200, Michal Privoznik wrote:
> On 04.08.2016 12:19, Pavel Hrdina wrote:
> > On Wed, Jul 27, 2016 at 10:43:50AM +0200, Michal Privoznik wrote:
> >> This element will control secure boot implemented by some
> >> firmwares. If the firmware used in <loader/> does support the
> >> feature we must tell it to the underlying hypervisor. However, we
> >> can't know whether loader does support it or not just by looking
> >> at the file. Therefore we have to have an attribute to the
> >> element where users can tell us whether the firmware is secure
> >> boot enabled or not.
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> >> ---
> >>  docs/formatdomain.html.in                          |  7 ++--
> >>  docs/schemas/domaincommon.rng                      |  8 +++++
> >>  src/conf/domain_conf.c                             | 14 ++++++++
> >>  src/conf/domain_conf.h                             |  1 +
> >>  .../qemuxml2argv-bios-nvram-secure.xml             | 41 ++++++++++++++++++++++
> > 
> > This XML file should be part of the next patch.
> 
> In fact, I always thought that XML test files should go hand in hand
> with our parser/formatter & schema changes. I mean, the .xml file I'm
> introducing is checked to be compliant with the RNG schema.
> I think the XML file can be viewed as a test for RNG schema change.

I thought about this too that it is checked by our RNG schema test.  I'm not
against to leave it in this patch, but for RNG schema tests there is
tests/domainschemadata folder.  In this case it's pointless to create a separate
schema test because it will be covered by XML file for qemuxml2argv test.
I just thought that it would be better to keep it close to the qemuxml2argv test
but if you don't want to move it to the next patch I can live with that :)

Pavel