[libvirt] [PATCH v5 6/9] conf: Add new secret element for tcp chardev

[Daniel P. Berrange]

On Thu, Aug 04, 2016 at 11:21:24AM -0400, John Ferlan wrote:
> Define, parse, and format a key secret element for a chardev tcp backend.
> This secret will be used in conjunction with the chartcp_tls_x509_cert_dir
> in order to provide the secret to the TLS encrypted TCP chardev.
> 
>     <secret type='tls' usage='tlsexample'/>
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  docs/formatdomain.html.in                          | 29 ++++++++++++
>  docs/schemas/domaincommon.rng                      | 21 +++++++++
>  src/conf/domain_conf.c                             | 35 +++++++++++++++
>  src/conf/domain_conf.h                             |  3 ++
>  ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 51 ++++++++++++++++++++++
>  ...ml2xmlout-serial-tcp-tlsx509-secret-chardev.xml |  1 +
>  tests/qemuxml2xmltest.c                            |  1 +
>  7 files changed, 141 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-secret-chardev.xml

Hmm, it feels little odd that we're having to give the password in
the XML, for a certificate thats configured in qemu.conf. I wonder
if we instead need to have the secret UUID listed in qemu.conf too


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|