[libvirt] [PATCH] lxcDomainCreateXMLWithFiles: Avoid crash

[Pavel Hrdina]

On Thu, Aug 04, 2016 at 04:50:29PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1363773
> 
> Imagine that you're creating a transient domain, but for some reason,
> starting it fails. That is virLXCProcessStart() returns an error. With
> current code, in the error handling code the domain object is removed
> from the domain object list, @vm is set to NULL and controls jump to
> enjob label where virLXCDomainObjEndJob() is called which dereference vm
> leading to instant crash.
> 
> The fix is to end the job in the error handling code and only after that
> remove the domain from the list and jump onto cleanup label instead of
> endjob.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---

ACK