[libvirt] [PATCH 3/3] virNetDevMacVLanCreateWithVPortProfile: Drop @ret

Ján Tomko jtomko at redhat.com
Wed Aug 10 14:30:31 UTC 2016


On Tue, Aug 09, 2016 at 07:32:45PM +0200, Michal Privoznik wrote:
>Usually, this variable is used to hold the return value for a
>function of ours. Well, this is not the case. Its use does not
>match our pattern and therefore it is very misleading. Drop it
>and define an alternative @rc variable, but only in that single
>block where it is needed.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/util/virnetdevmacvlan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160810/fb229302/attachment-0001.sig>


More information about the libvir-list mailing list