[libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

Xian Han Yu xhyubj at linux.vnet.ibm.com
Thu Aug 11 09:39:06 UTC 2016

On 8/11/2016 5:00 PM, Daniel P. Berrange wrote:
> On Thu, Aug 11, 2016 at 10:55:44AM +0200, Andrea Bolognani wrote:
>> On Thu, 2016-08-11 at 14:48 +0800, Xian Han Yu wrote:
>>>> The default is not OFF, though, it's ABSENT :)
>>>> In fact, as far as I can tell, OFF isn't ever used explicitly
>>>> either for assignment or comparison. And false is plain wrong
>>>> from a datatype point of view.
>>> How about we change all three occurrences as boris list above
>> Sure, that's exactly what I suggested :)
> IMHO, we should just do what Michael suggested right at the start of this
> thread and use  {0}, instead of manually initializing each field to
> 0, or a constant hiding the 0.
> Regards,
> Daniel

That maybe change back again in the future, if this struct add a new member
or current member need to be  not zero-initialized.

More information about the libvir-list mailing list