[libvirt] Failing build on rawhide

[Martin Kletzander]

So after updating my fedora-rawhide machines, I started receiving an
interesting error:

In file included from /usr/include/features.h:397:0,
                 from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/stdio.h:28,
                 from ../gnulib/lib/stdio.h:43,
                 from util/vircgroup.c:26:
/usr/include/sys/sysmacros.h:88:1: note: declared here
 __SYSMACROS_DEFINE_MINOR (__SYSMACROS_FST_IMPL_TEMPL)
 ^
util/vircgroup.c: In function 'virCgroupAllowDevicePath':
util/vircgroup.c:2944:33: error: '__major_from_sys_types' is deprecated:
  In the GNU C Library, `major' is defined by <sys/sysmacros.h>.
  For historical compatibility, it is currently defined by
  <sys/types.h> as well, but we plan to remove this soon.
  To use `major', include <sys/sysmacros.h> directly.
  If you did not intend to use a system-defined macro `major',
  you should #undef it after including <sys/types.h>.
  [-Werror=deprecated-declarations]
                                 major(sb.st_rdev),
                                 ^~~~~

It looks like we might need to reorder the includes, but whatever I do,
I still get the warning.  Updating gnulib doesn't help, so either we
need to #undef minor/major/makedev, or maybe gnulib needs to fix that
(my guess inspired by the include stack above).

So I figured I just post my findings here and let others continue the
wondering so that I can do some more useful stuff.

Have a nice day,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160811/a50d8447/attachment-0001.sig>