[libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

[Ján Tomko]

On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote:
>On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote:
>> On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote:
>> > On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote:
>> > > <controller type='scsi' index='0' model='virtio-scsi'>
>> > >     <virtio revision='0.9'/>
>> >
>> > I'm wondering about generalizing this. eg what if there are
>> > other device models where we want the ability to set a
>> > revision. We don't really want to invent a new sub-elment
>> > named after each device model
>>
>> Not even a new attribute? :)
>>  <revision virtio='0.9'/>
>>
>> How about:
>>  <revision type='virtio' version='0.9'/>
>
>Both of those are quite repetative - we already know its virtio.
>

I guess one device having <revision>s of different types is unlikely.

>Most devices we have alrady include a <driver> or <model> sub-element,
>so we should really just add a revision= attrbute to those existing

What I liked about having it as a separate element is that it can be
repeated, e.g.:
  <revision type='virtio' version='0.9'/>
  <revision type='virtio' version='1.0'/>

for a device with both 0.9 and 1.0.

I could not come up with a nice way to represent that in a single
attribute:
* '0.9+1.0' feels like the two values should rather be separated
  at the XML level
* 'all' will not be true if there happens to be another virtio
  revision in the future

Jan

>elements. For places which don't already have this we can add a new
><driver> element
>
>
>Regards,
>Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160811/bb610057/attachment-0001.sig>