[libvirt] [PATCH] qemu: driver: Fix format characters in error message

Peter Krempa pkrempa at redhat.com
Tue Aug 16 08:11:18 UTC 2016


Error message in qemuDomainSetVcpusFlags uses %d for the two arguments
but both are unsigned. The resulting error message may be weird when
attempting to set a very large vcpu count.
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5a7733c..a0587e1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4826,7 +4826,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
     if (!(flags & VIR_DOMAIN_VCPU_MAXIMUM) && nvcpus > maxvcpus) {
         virReportError(VIR_ERR_INVALID_ARG,
                        _("requested vcpus is greater than max allowable"
-                         " vcpus for the domain: %d > %d"),
+                         " vcpus for the domain: %u > %u"),
                        nvcpus, maxvcpus);
         goto endjob;
     }
-- 
2.9.2




More information about the libvir-list mailing list