[libvirt] [PATCH 17/27] qemu: setvcpus: Extract setting of maximum vcpu count

[Peter Krempa]

On Thu, Aug 11, 2016 at 10:02:55 +0200, Pavel Hrdina wrote:
> On Fri, Aug 05, 2016 at 03:56:13PM +0200, Peter Krempa wrote:
> > Setting of the maximum vcpu count is slightly semantically different
> > thus split it into a self-contained func.
> > ---
> >  src/qemu/qemu_driver.c | 47 +++++++++++++++++++++++++++++++----------------
> >  1 file changed, 31 insertions(+), 16 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 3e37f7e..cd1fb3d 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -4756,6 +4756,29 @@ qemuDomainSetVcpusAgent(virDomainObjPtr vm,
> 
> Since we can set only maximum or current number of vcpus and not both at the
> same time how about splitting the qemuDomainSetVcpusFlags function into two
> functions, one for maximum and second one for current?

Well, asking this in mid of a large series which certainly will cause
merge conflicts is a bit questionable but I will try to do it to make
you happy.

On the other hand, if I'd say that I'll do it after the series I'd
probably "forget" it since it's just code make up.

Peter