[libvirt] [PATCH v2 3/4] qemu: assign e1000e network devices to PCIe controllers when appropriate

[Andrea Bolognani]

On Mon, 2016-08-15 at 01:50 -0400, Laine Stump wrote:
> The e1000e is an emulated network device based on the Intel 82574,
> present in qemu 2.7.0 and later. Among other differences from the
> e1000, it presents itself as a PCIe device rather than legacy PCI. In
> order to get it assigned to a PCIe controller, this patch updates the
> flags setting for network devices when the model name is "e1000e".
> 
> (Note that for some reason libvirt has never validated the network
> device model names other than to check that there are no dangerous
> characters in them. That should probably change, but is the subject of
> another patch.)
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1343094
> ---
>  src/qemu/qemu_domain_address.c                     |  2 ++
>  tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args  | 24 +++++++++++--------
>  tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.xml   |  5 ++++
>  .../qemuxml2argv-q35-virtio-pci.args               |  4 ++++
>  .../qemuxml2argv-q35-virtio-pci.xml                |  5 ++++
>  .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 28 +++++++++++++++-------
>  .../qemuxml2xmlout-q35-virtio-pci.xml              | 10 ++++++++
>  7 files changed, 59 insertions(+), 19 deletions(-)

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization