[libvirt] [PATCH] network: write both lo and lo0 in dnsmasq configuration
Roman Bogorodskiy
bogorodskiy at gmail.com
Thu Dec 1 16:32:02 UTC 2016
Pino Toscano wrote:
> When generating a new configuration for dnsmasq, add except-interface
> for both lo and lo0: this should make sure the configuration works,
> and is always the same for every supported OS.
>
> Adjust the data of networkxml2conftest to reflect the new dnsmasq
> configuration, making networkxml2conftest pass on non-Linux OSes.
>
> Followup of commit 478ddedc12b77313cbaf72328ab2236ce7c56ead.
> ---
> src/network/bridge_driver.c | 9 ++++-----
> tests/networkxml2confdata/dhcp6-nat-network.conf | 1 +
> tests/networkxml2confdata/dhcp6-network.conf | 1 +
> tests/networkxml2confdata/dhcp6host-routed-network.conf | 1 +
> tests/networkxml2confdata/isolated-network.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-forward-plain.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-forwarders.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-hosts.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-local-domain.conf | 1 +
> .../networkxml2confdata/nat-network-dns-srv-record-minimal.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-srv-record.conf | 1 +
> tests/networkxml2confdata/nat-network-dns-txt-record.conf | 1 +
> tests/networkxml2confdata/nat-network-name-with-quotes.conf | 1 +
> tests/networkxml2confdata/nat-network.conf | 1 +
> tests/networkxml2confdata/netboot-network.conf | 1 +
> tests/networkxml2confdata/netboot-proxy-network.conf | 1 +
> tests/networkxml2confdata/open-network.conf | 1 +
> tests/networkxml2confdata/routed-network-no-dns.conf | 1 +
> tests/networkxml2confdata/routed-network.conf | 1 +
> 19 files changed, 22 insertions(+), 5 deletions(-)
Thanks, this indeed makes networkxml2conftest pass on FreeBSD. Basic
run-time tests doesn't reveal any issues as well (though I'm not sure
that I was ever able to reproduce the issue caused adding the
except-interface thing).
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161201/7509cb6a/attachment-0001.sig>
More information about the libvir-list
mailing list