[libvirt] [PATCH python] libvirt-override: fix setBlockIoTune failure passed

[Peter Krempa]

On Tue, Dec 06, 2016 at 10:47:51 +0800, xieyingtai at huawei.com wrote:
> From: Yingtai Xie <xieyingtai at huawei.com>
> 
> virDomainGetBlockIoTune() will be called before setBlockIoTune, as a result,
> it leads to a failure if set flags with VIR_DOMAIN_AFFECT_LIVE |
> VIR_DOMAIN_AFFECT_CONFIG which is an reasonable option.
> 
> Signed-off-by: Yingtai Xie <xieyingtai at huawei.com>
> ---
>  libvirt-override.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt-override.c b/libvirt-override.c
> index 2de95ce..caa52fb 100644
> --- a/libvirt-override.c
> +++ b/libvirt-override.c
> @@ -4805,6 +4805,7 @@ libvirt_virDomainSetBlockIoTune(PyObject *self ATTRIBUTE_UNUSED,
>      Py_ssize_t size = 0;
>      const char *disk;
>      unsigned int flags;
> +    unsigned int flags1 = 0;

You don't need a extra variable for what you've done below. Also the
variable name does not really give an idea what it's used for.

Either choose a better name, or drop the variable completely.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161206/670391cd/attachment-0001.sig>