[libvirt] [PATCH] qemu: capabilities: Add gluster.debug_level detection for 2.8.0+

Eric Blake eblake at redhat.com
Tue Dec 6 16:07:54 UTC 2016


On 12/06/2016 10:00 AM, Peter Krempa wrote:
> Qemu 2.8.0+ changes arguments structure for blockdev-add in the effort
> to make it finally stable. Since libvirt recently added the detection of
> gluster debug support relying on the old syntax we need to add the new
> as well.
> ---
>  src/qemu/qemu_capabilities.c                     | 1 +
>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index df417f2..214f848 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -1725,6 +1725,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsUSBNECXHCI[] = {
>  /* see documentation for virQEMUCapsQMPSchemaGetByPath for the query format */
>  static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = {
>      { "blockdev-add/arg-type/options/+gluster/debug-level", QEMU_CAPS_GLUSTER_DEBUG_LEVEL},
> +    { "blockdev-add/arg-type/+gluster/debug-level", QEMU_CAPS_GLUSTER_DEBUG_LEVEL},

Except that in 2.8, it will be spelled 'debug', not 'debug-level':
https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00572.html
https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00567.html

debug-level should only be used in 2.7.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161206/01ea03a6/attachment-0001.sig>


More information about the libvir-list mailing list