[libvirt] [PATCH] test: fix screenshot API impl

[Daniel P. Berrange]

On Tue, Dec 06, 2016 at 04:38:20PM +0100, Andrea Bolognani wrote:
> On Tue, 2016-12-06 at 13:04 +0000, Daniel P. Berrange wrote:
> > On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote:
> > > 
> > > On Tue, Dec 06, 2016 at 12:49:21 +0000, Daniel Berrange wrote:
> > > > 
> > > > When redoing the website we deleted the libvirtLogo.png file
> > > > not remembering that the test driver screenshot API impl
> > > > relied on it.
> > > > 
> > > > Rather than having the test driver use the logo as a side
> > > > effect, give it its own dedicated image to use. This is
> > > > installed in /usr/share/libvirt/test-screenshot.png and
> > > 
> > > Is it worth wasting 48k of disk space for a picture that almost nobody
> > > ever will see on every installation of libvirt?
> > 
> > 48k is completely lost in the noise when you consider the minimal install
> > footprint of libvirt. libvirt-libs is 23 MB in size, not even counting
> > the dependancies it pulls in.
> 
> How about a pngcrush'd 640x480 solid color? Not only it would
> be way smaller, but we would also remove any possible confusion
> about it being an actual screenshot of a running domain.

I think it is desirable to have it look like an actual screenshot,
so that its looks real when testing actual apps with this. This
image is not significantly different in size to the libvirtLogo.png
image we have been installing for use by the test driver in previous
releases, until the regression. So i really don't see size as being
a reason to not do this.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|