[libvirt] [PATCH] test: fix screenshot API impl

Andrea Bolognani abologna at redhat.com
Wed Dec 7 08:42:09 UTC 2016

On Tue, 2016-12-06 at 16:54 +0000, Daniel P. Berrange wrote:
> > How about a pngcrush'd 640x480 solid color? Not only it would
> > be way smaller, but we would also remove any possible confusion
> > about it being an actual screenshot of a running domain.
> I think it is desirable to have it look like an actual screenshot,
> so that its looks real when testing actual apps with this.

IMHO the more test data looks like, well, test data, the
better. Then again, it's not very likely that someone will
have an actual NeXT guest on their computer, so I guess
that fits the bill.

> This
> image is not significantly different in size to the libvirtLogo.png
> image we have been installing for use by the test driver in previous
> releases, until the regression. So i really don't see size as being
> a reason to not do this.

Fair enough.

Andrea Bolognani / Red Hat / Virtualization

More information about the libvir-list mailing list