[libvirt] [PATCH] test: fix screenshot API impl
Daniel P. Berrange
berrange at redhat.com
Wed Dec 7 09:52:44 UTC 2016
On Wed, Dec 07, 2016 at 10:30:56AM +0100, Michal Privoznik wrote:
> On 06.12.2016 13:49, Daniel P. Berrange wrote:
> > When redoing the website we deleted the libvirtLogo.png file
> > not remembering that the test driver screenshot API impl
> > relied on it.
> > Rather than having the test driver use the logo as a side
> > effect, give it its own dedicated image to use. This is
> > installed in /usr/share/libvirt/test-screenshot.png and
> > is taken from a NeXT Cube running WorldWideWeb. The
> > very first web browser in existance, running on the
> > hardware it was originally written on.
> >  https://en.wikipedia.org/wiki/WorldWideWeb
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> > libvirt.spec.in | 2 ++
> > mingw-libvirt.spec.in | 4 ++++
> > src/Makefile.am | 6 ++++++
> > src/test/test-screenshot.png | Bin 0 -> 45394 bytes
> > src/test/test_driver.c | 2 +-
> > 5 files changed, 13 insertions(+), 1 deletion(-)
> > create mode 100644 src/test/test-screenshot.png
> ACK from me, although I'm gonna miss that nice logo we returned earlier.
> Well it was merged as an April's fools prank anyway.
Oh, we can still have the logo hidden in the screenshot as an easter
egg :-) v2 coming up....
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
More information about the libvir-list