[libvirt] [PATCH v2] test: fix screenshot API impl
Michal Privoznik
mprivozn at redhat.com
Wed Dec 7 10:14:28 UTC 2016
On 07.12.2016 10:52, Daniel P. Berrange wrote:
> When redoing the website we deleted the libvirtLogo.png file
> not remembering that the test driver screenshot API impl
> relied on it.
>
> Rather than having the test driver use the logo as a side
> effect, give it its own dedicated image to use. This is
> installed in /usr/share/libvirt/test-screenshot.png and
> is taken from a NeXT Cube running WorldWideWeb[1]. The
> very first web browser in existance, running on the
> hardware it was originally written on.
>
> [1] https://en.wikipedia.org/wiki/WorldWideWeb
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>
> Changed in v2:
>
> - Recompressed with ImageMagick screenshot to be 25% smaller
> - Added easter egg to screenshot
Ah, very well. It took me a while to find it, but I did :-)
>
> libvirt.spec.in | 2 ++
> mingw-libvirt.spec.in | 4 ++++
> src/Makefile.am | 6 ++++++
> src/test/test-screenshot.png | Bin 0 -> 33443 bytes
> src/test/test_driver.c | 2 +-
> 5 files changed, 13 insertions(+), 1 deletion(-)
> create mode 100644 src/test/test-screenshot.png
ACK
Michal
More information about the libvir-list
mailing list