[libvirt] [PATCH] virsh: maxvcpus: Always fall back to the old command if domain caps fail

Peter Krempa pkrempa at redhat.com
Thu Dec 8 08:45:23 UTC 2016

1ec22be5 added code that detects the maximum cpu count according to
domain capabilities. The code fell back to the old command only if the
API was not supported. If the API fails for other reasons the command
would fail. There's no point in not trying the old API in such case.

 tools/virsh-host.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index 2fd3686..24ebde2 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -623,9 +623,6 @@ cmdMaxvcpus(vshControl *ctl, const vshCmd *cmd)

         ignore_value(virXPathInt("string(./vcpu[1]/@max)", ctxt, &vcpus));
     } else {
-        if (last_error && last_error->code != VIR_ERR_NO_SUPPORT)
-            goto cleanup;


More information about the libvir-list mailing list