[libvirt] [PATCH 1/3] qemu: agent: fix uninitialized var case in qemuAgentGetFSInfo

[John Ferlan]

On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote:
> In case of 0 filesystems *info is not set while according
> to virDomainGetFSInfo contract user should call free on it even
> in case of 0 filesystems. Thus we need to properly set
> it. NULL will be enough as free eats NULLs ok.
> ---
>  src/qemu/qemu_agent.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
> index ec8d47e..c5cf403 100644
> --- a/src/qemu/qemu_agent.c
> +++ b/src/qemu/qemu_agent.c
> @@ -1872,6 +1872,7 @@ qemuAgentGetFSInfo(qemuAgentPtr mon, virDomainFSInfoPtr **info,
>      ndata = virJSONValueArraySize(data);
>      if (!ndata) {
>          ret = 0;
> +        *info = NULL;

ACK - although there are more ways above this hunk that allow us to get
to cleanup without setting *info = NULL;  Currently each of the callers
sets the input info to NULL before calling here

IOW: We could also move that *info = NULL up before the call to
virAgentMakeCommand


John

>          goto cleanup;
>      }
>      if (VIR_ALLOC_N(info_ret, ndata) < 0)
>