[libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6
Daniel P. Berrange
berrange at redhat.com
Tue Dec 13 11:16:24 UTC 2016
On Tue, Dec 13, 2016 at 12:04:17PM +0100, Michal Privoznik wrote:
> On 13.12.2016 11:51, Daniel P. Berrange wrote:
> > On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote:
> >> These builds often fails with false positives due to ancient
> >> compiler found on this system. For instance it fails to see when
> >> symbol is used as a variable and when it is used as a function
> >> producing the following warnings:
> >> ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat':
> >> ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow]
> >> /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow]
> >> Users trying to use libvirt from git on stable system are doomed
> >> to fix it themselves.
> > NACK, CentOS 6 is a supported platform and we need to make sure
> > we continue to build on there. Working around these compiler warnings
> > is not hard.
> I know it is supported but frankly I've never tried running git libvirt
> there. Do we even know it still works? Otherwise our claim is just an
> empty promise that we do compile cleanly there.
Just because we don't have automated testing doesn't mean the code has
stopped working. You can say the same about pretty much every single
distro, since we don't have our CI running integration tests yet. This
is a gap I'd like to see us address, though it likely requires us to
get more hardware resource, since the current CI host is pretty fully
loaded just doing builds.
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
More information about the libvir-list