[libvirt] [PATCH 1/2] qemu: monitor: Don't resume lockspaces in resume event handler

[Peter Krempa]

After qemu delivers the resume event it's already running and thus it's
too late to enter lockspaces since it may already have modified the
disk. The code only creates false log entries in the case when locking
is enabled. The lockspace needs to be acquired prior to starting cpus.
---
 src/qemu/qemu_process.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 387103481..3f892fcee 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -773,17 +773,6 @@ qemuProcessHandleResume(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
                                          VIR_DOMAIN_EVENT_RESUMED,
                                          VIR_DOMAIN_EVENT_RESUMED_UNPAUSED);

-        VIR_DEBUG("Using lock state '%s' on resume event", NULLSTR(priv->lockState));
-        if (virDomainLockProcessResume(driver->lockManager, cfg->uri,
-                                       vm, priv->lockState) < 0) {
-            /* Don't free priv->lockState on error, because we need
-             * to make sure we have state still present if the user
-             * tries to resume again
-             */
-            goto unlock;
-        }
-        VIR_FREE(priv->lockState);
-
         if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
             VIR_WARN("Unable to save status on vm %s after state change",
                      vm->def->name);
-- 
2.11.0