[libvirt] [PATCH v5 0/3] gluster: cache glfs connection object per volume

Prasanna Kumar Kalever prasanna.kalever at redhat.com
Thu Dec 15 08:07:02 UTC 2016


v5: Address review comments from Peter on v4
Dropping Patch 3 from v3
Patch 1: fix transport type in all drivers, possible switch case converts
Patch 2: use virObject with src->drv to avoid 'initFlag' for
         remembering 'virStorageFileInit' status
Patch 3:
* change virStorageBackendGlusterCacheQuery to *Lookup
* change virStorageBackendGlusterCacheRefresh to *Release
* Avoid the global Flags
* Thread safe measure by using virCond*
Thanks Peter!

v4: Address review comments from Peter on v3
Patch 1: changes to fix test failures
         (qemuargv2xmltest, qemuxml2argvtest, qemuxml2xmltest and virstoragetest)
Patch 2: fix hung in qemuxml2argvtest
Patch 3 v3: Split this Patch to 2 parts as below
Patch 3 v4: don't free metadata used for storage driver access
Patch 4:
* update variable naming as per standards
* virStorageBackendGlusterPreopened* -> virStorageBackendGlusterCache*
Thanks Peter!

v3: Address comments by Daniel and Peter on v2
* Split the patch to 3 parts
Patch 1: change the virStorageNetHostDef type
Patch 2: optimize calls to virStorageFileInit and friends
Patch 3: add the caching for glfs
* Thanks to Daniel, this version make all the methods as thread safe
* Thanks to Peter for pointing use of virObjectLockable, this had simplified
  rest of the parts a lot.

v2: Address review comments from Peter on v1
* Rebased on latest master
* Changes to commit msg
* Introduce storage API's for Register and Unregister of volume
* During qemu process Start/Stop and snapshot create
* Check Transport and Port type
* Atomic element add/del to list and ref counting
Pending: Treating IP and FQDN belong to same host

v1: Initial patch

Prasanna Kumar Kalever (3):
  util: change the virStorageNetHostDef type
  storage: optimize calls to virStorageFileInit and friends
  gluster: cache glfs connection object per volume

 src/conf/domain_conf.c                           |  60 +++--
 src/libxl/libxl_conf.c                           |  10 +-
 src/qemu/qemu_command.c                          |  97 ++++---
 src/qemu/qemu_domain.c                           |  25 +-
 src/qemu/qemu_domain.h                           |   8 +-
 src/qemu/qemu_driver.c                           |  26 +-
 src/qemu/qemu_parse_command.c                    |  50 ++--
 src/qemu/qemu_process.c                          |  49 ++++
 src/qemu/qemu_process.h                          |   4 +
 src/storage/storage_backend.h                    |   1 +
 src/storage/storage_backend_fs.c                 |   5 +
 src/storage/storage_backend_gluster.c            | 329 ++++++++++++++++++++---
 src/storage/storage_driver.c                     |  40 ++-
 src/storage/storage_driver.h                     |   2 +
 src/util/virstoragefile.c                        |  93 ++++---
 src/util/virstoragefile.h                        |  21 +-
 src/xenconfig/xen_xl.c                           |  10 +-
 tests/domainsnapshotxml2xmlin/disk_snapshot.xml  |   2 +-
 tests/domainsnapshotxml2xmlout/disk_snapshot.xml |   2 +-
 tests/virstoragetest.c                           |   2 +-
 20 files changed, 614 insertions(+), 222 deletions(-)

-- 
2.7.4




More information about the libvir-list mailing list